Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor errors in unit tests (mostly typing) #1902

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

ntziolis
Copy link
Contributor

@ntziolis ntziolis commented Apr 5, 2021

Description

A number of unit tests contained minor errors (mostly typing and missing parameters). These are resolved now.

Fixes #1901

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

All existing unit tests were successfully executed.

Test Environment:

  • OS: Windows
  • NodeJS: 12.18.3

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

It might be worth adding the appropriate transforms to the jest config to ensure unit tests fail when such errors are checked in.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2021

⚠️ No Changeset found

Latest commit: a89826c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ntziolis ntziolis changed the title Fixed minor errors in unit tests Fixed minor errors in unit tests (mostly typing) Apr 5, 2021
@ardatan
Copy link
Owner

ardatan commented Apr 6, 2021

Thank you @ntziolis !

@ardatan ardatan merged commit 47437a0 into ardatan:master Apr 6, 2021
klippx pushed a commit to klippx/graphql-mesh that referenced this pull request Oct 9, 2024
* chore(deps): update all non-major dependencies

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
klippx pushed a commit to klippx/graphql-mesh that referenced this pull request Oct 9, 2024
* chore(deps): update all non-major dependencies

* chore(dependencies): updated changesets for modified dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants