Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Transfer schema Transform #3185

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

santino
Copy link
Contributor

@santino santino commented Nov 17, 2021

Description

This PR introduces a new transform to copy and/or move parts of a GraphQL schema.
It allows to copy/move fields from one Type to another.
Similarly, it also allows to copy/move args from one field to another.

This PR takes inspiration from #2975 and would eventually supersede #3041

cc @ntziolis, @Lappihuan

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

New tests have been introduced

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

I will probably add a few more tests (e.g copy/move fields for non Root Types).
I also need to write the documentation, I will wait for feedback on this PR before doing this so that eventually I do this once API is fully approved.

In the meantime, all tests available are in working order and can serve as an explanation of what the transform does and how it can be used.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

⚠️ No Changeset found

Latest commit: f004305

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

API changes (scope => action, remove rename func, simplify syntax)

finalise functional implementation

update snapshot
@ardatan ardatan merged commit 9db3e98 into ardatan:master Apr 4, 2023
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
@theguild-bot theguild-bot mentioned this pull request Sep 28, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants