Refactor cryptologic initialisation code #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce 'delete' can handle a NULL value
…nt has been assigned a valid value - it should have the NULL value assigned at object construction
…in method to dedicated util class CryptoUtil for better readability
…uctCertificate' which allows for a similiar check/control flow in 'ArduinoIoTCloud::begin'
…only needed there
|
Closing this because this changes are contained in PR #109 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a refactoring of the code used to initialize and read from the crypto chip and has been successfully tested on PROD with:
MKR WiFi 1010✔️ESP8266✔️@AlbyIanna Since
Provisioning.inohas been modified can you please check if the getting started process still works at it should (it should, but checking can't hurt).