possibility to disable logging #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
reviewed
Feb 15, 2019
| @@ -18,9 +18,7 @@ | |||
| #ifndef CONNECTION_MANAGER_H_INCLUDED | |||
| #define CONNECTION_MANAGER_H_INCLUDED | |||
|
|
|||
| #ifndef ARDUINO_CLOUD_DEBUG_LEVEL | |||
There was a problem hiding this comment.
I'd leave the guard to allow multiple inclusion of this file
There was a problem hiding this comment.
@facchinm this is only to define a default in case it wasn't defined in the sketch, but it's definitely not needed anymore.
there's still a check against multiple inclusion
facchinm
reviewed
Feb 15, 2019
| @@ -77,7 +75,10 @@ class ConnectionManager { | |||
| #endif | |||
|
|
|||
| static int debugMessageLevel = ARDUINO_CLOUD_DEBUG_LEVEL; | |||
| inline void debugMessage(char *_msg, uint8_t _debugLevel, bool _timestamp = true, bool _newline = true) { | |||
| inline void debugMessage(char *_msg, int _debugLevel, bool _timestamp = true, bool _newline = true) { | |||
| if(_debugLevel < 0){ | |||
There was a problem hiding this comment.
this check is probably not needed if we only allow messages from 0 up 🙂
There was a problem hiding this comment.
mh... better safe than sorry? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDebugMessageLevel()will now accept -1 to disable logging