Skip to content

Add compatibility to Portenta H7 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Add compatibility to Portenta H7 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe6d4e2
Fix setGains() argument in example
facchinm Nov 3, 2021
f89b416
Fix compilation for Portenta H7
facchinm Nov 3, 2021
a0180db
Merge branch 'master' into portenta_compatibility
aentinger Dec 30, 2022
4802670
Fix CI build error also for H7/M4 core.
aentinger Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/MKR/Test/Test.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void setup() {
// This way, you can program the motor to reach a certain position or velocity without any further intervention.
// The PID can be carefully tuned if a particular profile is needed.
pid1.setControlMode(CL_POSITION);
pid1.setGains(25, 0, 3);
pid1.setGains(25.0f, 0.0f, 3.0f);
pid1.setMaxAcceleration(4000);
pid1.setSetpoint(TARGET_POSITION, 5000);
}
Expand Down
4 changes: 4 additions & 0 deletions src/Common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/

#if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4)
#define RESET _RESET
#endif

enum Commands {
GET_VERSION = 0x01,
RESET,
Expand Down