Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving Caps/Num/Scroll Lock Status #40

Open
SukkoPera opened this issue Aug 18, 2020 · 3 comments · May be fixed by #61
Open

Allow retrieving Caps/Num/Scroll Lock Status #40

SukkoPera opened this issue Aug 18, 2020 · 3 comments · May be fixed by #61
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@SukkoPera
Copy link

This patch applies (mostly) cleanly to the sources included with Arduino 1.8.13 and seems to work well for the purpose, while sporting a simple interface.

I think it should really be considered for inclusion upstream.

@phuse
Copy link

phuse commented Dec 16, 2020

was just looking for exactly this since I'm hacking together a numerical/macro keyboard

@PJ789
Copy link
Contributor

PJ789 commented Dec 26, 2021

I can vouch for this patch too. It is working well here against current keyboard code. There is a dependency on the HID library that means I'm hesitating to offer it as a pull request. Perhaps it can be made more specific to the keyboard library without unintended side effects on the HID library..?

@per1234 per1234 added the type: enhancement Proposed improvement label Dec 26, 2021
@PJ789
Copy link
Contributor

PJ789 commented Dec 26, 2021

Two pull requests created to incorporate this feature;

  1. Keyboard library pull request 61

which depends upon

  1. ArduinoCore-avr library pull request 446

regards
Pete

@per1234 per1234 linked a pull request Mar 6, 2022 that will close this issue
@per1234 per1234 added the topic: code Related to content of the project itself label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants