Ethernet library assigns incorrect IP Address.

[Alienwaren]

Hello, I found annoying bug in Ethernet Library. When I want to use static IP Address not from DHCP, it assigns incorrect IP Address. Everything in it is incorrect, not even one octet is correct. Getting IP from DHCP does not reproduce problem; assigned IP is correct.
I'm using Arduino Uno R3 with Ethernet Shield clone, Arduino 1.5.6-r2, using following code:

#include <SPI.h>
#include <Ethernet.h>
#include <HttpClient.h>
#include <Xively.h>
#include <OneWire.h>

// MAC address for your Ethernet shield
byte mac[] = { 0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED };
IPAddress ipXively(192, 168, 0, 20);
IPAddress gateway(192,168,0,1);
IPAddress netmask(255,255,255,0);
// Your Xively key to let you upload data
char xivelyKey[] = "xyz";

// Analog pin which we're monitoring (0 and 1 are used by the Ethernet shield)
int sensorPin = A0;

// Define the strings for our datastream IDs
char sensorId[] = "xyz";
XivelyDatastream datastreams[] = {
  XivelyDatastream(sensorId, strlen(sensorId), DATASTREAM_FLOAT),
};
// Finally, wrap the datastreams into a feed
XivelyFeed feed(458360579, datastreams, 1 /* number of datastreams */);

EthernetClient client;
XivelyClient xivelyclient(client);

void setup() {
  // put your setup code here, to run once:
  Serial.begin(9600);
  analogReference(DEFAULT);
  Serial.println("Starting single datastream upload to Xively...");
  Serial.println();

  Ethernet.begin(mac, ipXively, gateway, netmask);
  Serial.println(Ethernet.localIP());
  /////////////////////////////////
}

void loop() {
  float sensorValue = analogRead(sensorPin);
  float voltage = sensorValue * (5.0 / 1023);
    datastreams[0].setFloat(voltage);
  Serial.print("Read sensor value ");
  Serial.println(datastreams[0].getFloat());
  Serial.println("Uploading it to Xively");
  int ret = xivelyclient.put(feed, xivelyKey);
  Serial.print("xivelyclient.put returned ");
  Serial.println(ret);
  Serial.println();
  delay(5000);
  float temperature = getTemp(3);
  Serial.println(temperature);
}
float getTemp(int pin)
{
  OneWire ds(pin);  // on some pin (PULLUP!)
  byte i;
  byte present = 0;
  byte type_s;
  byte data[12];
  byte addr[8];
  float celsius, fahrenheit;

  if ( !ds.search(addr)) {
    Serial.println("No more addresses.");
    Serial.println();
    ds.reset_search();
    delay(250);
    return -5000;
  }else
  {
    ds.reset();
    ds.select(addr);
    ds.write(0x44, 1);        // start conversion, with parasite power on at the end\

    delay(1000);     // maybe 750ms is enough, maybe not
    // we might do a ds.depower() here, but the reset will take care of it.

    present = ds.reset();
    ds.select(addr);    
    ds.write(0xBE);         // Read Scratchpad
    for ( i = 0; i < 9; i++) {           // we need 9 bytes
    data[i] = ds.read();
    Serial.print(data[i], HEX);
    Serial.print(" ");
     int16_t raw = (data[1] << 8) | data[0];
    if (type_s) {
    raw = raw << 3; // 9 bit resolution default
    if (data[7] == 0x10) {
      // "count remain" gives full 12 bit resolution
      raw = (raw & 0xFFF0) + 12 - data[6];
    }
    } else {
    byte cfg = (data[4] & 0x60);
    // at lower res, the low bits are undefined, so let's zero them
    if (cfg == 0x00) raw = raw & ~7;  // 9 bit resolution, 93.75 ms
    else if (cfg == 0x20) raw = raw & ~3; // 10 bit res, 187.5 ms
    else if (cfg == 0x40) raw = raw & ~1; // 11 bit res, 375 ms
      //// default is 12 bit resolution, 750 ms conversion time
    }
    celsius = (float)raw / 16.0;
    fahrenheit = celsius * 1.8 + 32.0;
    return celsius;
    }
  }
}

The output on serial monitor (there is IP Address): [ScreenShot]
https://www.dropbox.com/s/6do3m761ey5jzob/Zrzut%20ekranu%202014-07-06%2011.51.25.png

[barbudor]

You have published your private Xively key.
For the sake of your account security, you should change it quickly.

[Alienwaren]

But it is changed... for xyz. And on site ofc is changed too.

[barbudor]

It's too late : everybody has received the original email with the original
key.

char xivelyKey[] = "6z03dY************************3uqQ241lGrlE";

You have to change it on Xively web site.
Just like a password.

[matthijskooijman]

As for the actual problem - I thought for a moment that LocalIP() might only work for DHCP, but looking at the code it reads from the SIPR register where the static IP is also written to.

Could you provide a minimal testcase, that just sets up the IP address and prints it? This rules out any interference from all of the other code in your example.

Did you test if the IP address printed is actually correct (e.g. by pinging the printed and configured IP)?

[Alienwaren]

@barbudor I changed API key already.
@matthijskooijman Let me try. I'll soon post test results

///EDIT:
Very weird thing. For now it's working, but without Micro SD (on the Ethernet shield one) card. I don't know why, but for now i'm working without Micro SD.
The code for test

#include <SPI.h>
#include <Ethernet.h>

// Enter a MAC address for your controller below.
// Newer Ethernet shields have a MAC address printed on a sticker on the shield
byte mac[] = { 0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED };
// Set the static IP address to use if the DHCP fails to assign
IPAddress ip(192, 168, 0, 50);

// Initialize the Ethernet client library
// with the IP address and port of the server
// that you want to connect to (port 80 is default for HTTP):
EthernetClient client;

void setup() {
  // Open serial communications and wait for port to open:
  Serial.begin(9600);

    Ethernet.begin(mac, ip);

}

void loop()
{
  Serial.println(Ethernet.localIP());
  delay(1000);
}
It prints correct IP (192.168.0.50)

[NitrofMtl]

got the very same bug here wiht an arduino DUE and Enet shield. even DHCP bug with sd card insert.
if I remove it, the same sketch work.

[PaulStoffregen]

Try adding this at the beginning of setup:

    pinMode(4, OUTPUT);
    digitalWrite(4, HIGH);
    delay(1);

These ethernet problems very well may be due to the SD card "hearing" the ethernet communication, because pin 4 is unconfigured and the Arduino Ethernet Shield lacks a pullup resistor on pin 4. When the SD chip select is (floating) low, it can respond and transmit on MISO, possibly corrupting communication from the W5100 chip.

More details on this type of problem here:

http://www.dorkbotpdx.org/blog/paul/better_spi_bus_design_in_3_steps

[NitrofMtl]

Yes thats fix it !! thankx a lot.That I should have search for a long time.

[PaulStoffregen]

The Arduino Ethernet shield and all other SPI-based boards should have pullup resistors on their chip select pins. I too have made boards without these resistors, and I will soon be updating my own designs.

I hope Arduino will consider adding pullup resistors on a future hardware revision.

The fact that this bug has been open for months, with multiple people weighing in, really shows how difficult and confusing this problem can be. Arduino users really deserve better, easy-to-use hardware with pullup resistors on the chip selects.

[NitrofMtl]

yes it sould be.
another thing; is the sd pin have to be set to high after each time it use fot the ethernet to work ?
cause after a small test, now the sketch begin but after the sketch use the sd card, the ethernet stop working...
thanks.

[Alienwaren]

Oh, great tips! Thanks guys :)

[PaulStoffregen]

I opened a new issue with a specific request to revise the hardware. I have no idea if Arduino will actually be willing to revise their board, but this is the best I can do.

I've also contacted Adafruit and Sparkfun. Some of their products have the pullups, others don't. They're going to start adding them on new products.

[NitrofMtl]

wow ! what a job. Just read your tread and I now better understand whats append.
great job thank you.