Issue 392, problem with 3 !, or !!! fix #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Typo in the commit message. fix for !!! |
|
There are a bunch of changes here. Can you make a version / diff that just fixes this particular bug? |
|
I'll review the change set and that will isolate the change more precisely. Then create another pull request. Thanks. |
|
Any update on getting a clean version of the fix? Even if it's just disabling the terminal altogether? I don't think many people are running into this, but it would be good to get the update into production. |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Update IR lib/sensor to use the latest IR_Remote fork by Chris Young
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Mark Sproul's fix for issue 392. The problem where 3 bangs would be parsed by the bootloader.
-_Rick
Note problems with use 3 bangs in descriptions.