Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trimming #11666

Closed
wants to merge 1 commit into from
Closed

Fix trimming #11666

wants to merge 1 commit into from

Conversation

thomasleplus
Copy link

@thomasleplus thomasleplus commented Sep 18, 2021

The trim() method returns a new trimmed string, it does not alter the current string (strings being immutable in Java).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

The trim() method returns a new trimmed string, it does not alter the current string (strings being immutable in Java).
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2021

CLA assistant check
All committers have signed the CLA.

for (String item : strArray) {
item.trim();
for (int i = 0; i < strArray.length; i++) {
strArray[i] = strArray[i].trim();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Java 8 is supported, we can use like below

import java.util.Arrays;
Arrays.parallelSetAll(strArray, (i) -> strArray[i].trim());

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Sadly I have deleted my fork so I can't modify this PR. I'll close it and submit a new one (#11710). Sorry for the inconvenience.

@per1234
Copy link
Collaborator

per1234 commented Nov 30, 2021

Superseded by #11710

@per1234 per1234 added Component: IDE The Arduino IDE Type: Duplicate Another item already exists for this topic Type: Bug labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE Type: Bug Type: Duplicate Another item already exists for this topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants