Skip to content

Conversation

thomasleplus
Copy link

@thomasleplus thomasleplus commented Sep 18, 2021

The trim() method returns a new trimmed string, it does not alter the current string (strings being immutable in Java).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

The trim() method returns a new trimmed string, it does not alter the current string (strings being immutable in Java).
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2021

CLA assistant check
All committers have signed the CLA.

for (String item : strArray) {
item.trim();
for (int i = 0; i < strArray.length; i++) {
strArray[i] = strArray[i].trim();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Java 8 is supported, we can use like below

import java.util.Arrays;
Arrays.parallelSetAll(strArray, (i) -> strArray[i].trim());

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Sadly I have deleted my fork so I can't modify this PR. I'll close it and submit a new one (#11710). Sorry for the inconvenience.

@per1234
Copy link
Collaborator

per1234 commented Nov 30, 2021

Superseded by #11710

@per1234 per1234 added Component: IDE The Arduino IDE Type: Duplicate Another item already exists for this topic Type: Bug labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE Type: Bug Type: Duplicate Another item already exists for this topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants