Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Serial Monitor open during upload #2809

Closed
wants to merge 5 commits into from

Conversation

@holgerlembke
Copy link

commented Mar 23, 2015

Keep Serial Monitor open during upload and don't break existing functions. I became aware that there is another solution after I did my implementation. So perhaps it is obsolete...

First try to work with Github, I need a nanny... :-)

Keep Serial Monitor open during upload
Keep Serial Monitor open during upload and don't break existing
functions.
@matthijskooijman

This comment has been minimized.

Copy link
Collaborator

commented Mar 23, 2015

There have been a few versions of solutions for this problem. The "accepted" solution so far is to disable the serial monitor during uploads, without closing the window. This is implemented by #2742. If you want to help out, you could perhaps test that code and report your findings?

Still, thanks for your contribution! Hopefully more to come?

If you think your PR adds something to #2742, please tell us what. Otherwise, it is probably better to close this PR?

@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 23, 2015

As far as I see, there are some notes that #2742 does not work on all platforms.

Perhaps this solution is more compatible...

@PaulStoffregen

This comment has been minimized.

Copy link
Collaborator

commented Mar 23, 2015

@ArduinoBot build this please

Send Board Reset from Serial Monitor
This  introduces two new features:

++ a reset button to the serial monitor. So the board can be reset by a
simple button press

++ the "reset board on serial monitor open" has been removed. I think
that removed "feature" was a great annoyance: imagine the Arduino is
controlling some device. And you forgot to open the monitor. Open it
later, Reset, Not nice.
@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 25, 2015

Hmm. Sorry for any confusion, but apparently I managed to add another change to this pull request. I intended to create two different pulls, on for each commit, but I failed. And I fear to create more chaos if I remove the second commit now.

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

@ArduinoBot build this please

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

It looks like the bot is sleeping

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

@ArduinoBot build this please

@ArduinoBot

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

Build failed.

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

Ok, it doesn't compile

compile:
    [mkdir] Created dir: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/bin
    [javac] Compiling 65 source files to /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/src/processing/app/NetworkMonitor.java:25: error: NetworkMonitor is not abstract and does not override abstract method closeSerial() in AbstractMonitor
    [javac] public class NetworkMonitor extends AbstractMonitor implements MessageConsumer {
    [javac]        ^
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
    [javac] 1 warning
@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 26, 2015

Mine here does.

I can add

@override
public void openSerial() throws Exception {}

@override
public void closeSerial() throws Exception {}

into networkmonitor.java

Perhaps it makes someone happy.

Change to keep the Arduinobot compiler happy
Mine compiles without it just fine. But...
@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 26, 2015

@ArduinoBot build this please

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2015

@holgerlembke I've tried it locally and fails the same way. Your commit https://github.com/holgerlembke/Arduino/commit/16adf827eee5600599b3efc36d4a9bd5811822a3 is about one blank line added

Change to keep the Arduinobot compiler happy
Second try, commited the wrong file.

I still don't understand why it compiles on Windows her without those
lines. I'm synced, the file is compiled (i checked that) and everything,
so it should.
@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 28, 2015

@ArduinoBot build this please

@holgerlembke

This comment has been minimized.

Copy link
Author

commented Mar 30, 2015

@ArduinoBot build this please.

@ffissore

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2015

@ArduinoBot build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.