Schematic View and Progress Bar (new-extension branch) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One quick question about the schematics view: it looks like you need to give the .png the same name as the sketch. What happens if you rename the sketch? Does the png get renamed too? |
|
No, it doesn't get renamed, personally i dislike this sort of automatism. |
|
Hmm, does it get renamed in Wiring? It could be nice to be consistent with them. But if not, using a fixed name seems like a reasonable solution. |
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Pressure sensor example fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go. The same patch but in new-extension branch.
I've slightly changed the original files coming from wiring: this one is a little bit optimized (unused variable/functions, dead code left around etc).
We still need someone that can give us a nice icon for the "show schematics" button.