Skip to content

SAM: add iSerial USB field #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2015
Merged

SAM: add iSerial USB field #4009

merged 1 commit into from
Oct 21, 2015

Conversation

facchinm
Copy link
Member

Porting of #3811 for SAM architecture
/cc @cmaglie

@cmaglie cmaglie self-assigned this Oct 21, 2015
@cmaglie cmaglie merged commit 775c82b into arduino:master Oct 21, 2015
@cmaglie cmaglie added Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) feature request A request to make an enhancement (not a bug fix) Architecture: SAM Applies only to the SAM microcontrollers (Due) labels Oct 21, 2015
@cmaglie cmaglie added this to the Release 1.6.6 milestone Oct 21, 2015
@ArduinoBot
Copy link
Contributor

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4009-BUILD-420-linux32.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4009-BUILD-420-linux64.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4009-BUILD-420-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4009-BUILD-420-macosx.zip

@NicoHood
Copy link
Contributor

Just a small note here:
If the plugged interface adds more than the 20 available chars this will write to undefined memory. I think its not needed to fix this, since this should not happen on a limited number on endpoints. But its sure a risk if people feel like writing stories to the field.

It should be noted in the docs though:
https://github.com/arduino/Arduino/wiki/PluggableUSB-and-PluggableHID-howto

@facchinm facchinm deleted the nativeUSB_serialNumber_due branch January 4, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmaglie cmaglie

Labels
Architecture: SAM Applies only to the SAM microcontrollers (Due) Component: USB Device Opposed to USB Host. Related to the USB subsystem (SerialUSB, HID, ...) feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Milestone
Release 1.6.6
Development

Successfully merging this pull request may close these issues.
4 participants
@facchinm @ArduinoBot @NicoHood @cmaglie