New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed serial port argument that may include spaces #6383

Merged
merged 1 commit into from Jul 25, 2017

Conversation

4 participants
@smartperson
Contributor

smartperson commented Jun 15, 2017

Other paths in avrdude.upload.pattern are wrapped in double quotes, and this -P{serial.port} causes issues with some platforms. This allows serial port devices which include spaces and other characters. Without this fix a /dev/tty* or /dev/cu* device that includes a space in its name gets truncated when passed to avrdude. Error messages returned from avrdude are cryptic, and workarounds (symlinks) are prone to failure.

Fixes #3693

Fixed Serial Port Argument That May Include Spaces
Other paths in avrdude.upload.pattern are wrapped in double quotes, and
this -P{serial.port} causes issues with some platforms. This allows
serial port devices which include spaces and other characters. Without
this fix a /dev/tty* or /dev/cu* device that includes a space in its
name gets truncated when passed to avrdude. Error messages returned
from avrdude are cryptic, and workarounds (symlinks) are prone to
failure.

Fixes #3693

@smartperson smartperson changed the title from Fixed Serial Port Argument that may include spaces to Fixed serial port argument that may include spaces Jun 15, 2017

@matthijskooijman

Looks good to me. @cmaglie, this is an easy merge, let's just pick it up?

@facchinm

Probably a double check on all architectures would be interesting too 🙂

@facchinm facchinm added this to the Release 1.8.4 milestone Jul 25, 2017

@cmaglie cmaglie merged commit 0fc235d into arduino:master Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment