Skip to content

Conversation

bblanchon
Copy link
Contributor

@bblanchon bblanchon commented Nov 14, 2017

Changed the signatures of Stream::find() and Stream::findUntil() to take const pointers, as they don't change the target.

Old signature New signature
find(char *target) find(const char *target)
findUntil(char *target, char *terminator) findUntil(const char *target, const char *terminator)

All the overloads have been changed accordingly.

This should not cause any code to break.

@facchinm facchinm added the Print and Stream class The Arduino core library's Print and Stream classes label Nov 14, 2017
@bblanchon
Copy link
Contributor Author

👋 Can someone have a look?

@facchinm
Copy link
Member

Hi @bblanchon ,
we are closing all the API related PRs in this repo.
If you are still interesting in getting this merged could you reopen in https://github.com/arduino/ArduinoCore-api ? Here you can find some hints about reapplying the patch to that repo easily.
Thanks!

@facchinm facchinm closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Print and Stream class The Arduino core library's Print and Stream classes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants