[STEPPER] Improvements to C++ code

[steve-weinrich]

• There are no functionality or interface changes. Just C++ improvements.
• Use a "pointer to member function" to divide "stepMotor" into discrete methods.
• Remove unnecessary use of "this".
• Add a common initialization method for use by all constructors.
• Add appropriate use of "const".
• Remove "direction" from class as it was only used in one method.
• Add "numberOfPositions" so that the "step" method does not need to test the motor type.
• Change the "motorPins" into an array to make common initialization easier.
• Use camel case variable names instead of underscores.

[facchinm]

Hi @steve-weinrich ,
would you mind moving the PR to https://github.com/arduino-libraries/Stepper/pulls ? Thanks

[steve-weinrich]

Howdy, No problem. Do you want me to integrate the other PR’s into this? Or just certain ones? Or none? Cheers. From: Martino Facchin [mailto:notifications@github.com] Sent: Monday, January 8, 2018 03:45 To: arduino/Arduino <Arduino@noreply.github.com> Cc: steve-weinrich <weinrich.steve@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [arduino/Arduino] [STEPPER] Improvements to C++ code (#7060) Hi @steve-weinrich <https://github.com/steve-weinrich> , would you mind moving the PR to https://github.com/arduino-libraries/Stepper/pulls ? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7060 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/Ag_Y2o6b6OuzAN3VxhegKA2fBsdWXKo0ks5tIfG8gaJpZM4RPThc> . <https://github.com/notifications/beacon/Ag_Y2gSv7mHA8eTnLFuNP6fKzBu2snXaks5tIfG8gaJpZM4RPThc.gif>

[facchinm]

Feel free to create a brand new PR with all your commits included 😉

[steve-weinrich]

Moving to arduino-libraries