Skip to content

Limit the SerialPlotter to max 20 graphs #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limit the SerialPlotter to max 20 graphs #7462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/src/processing/app/SerialPlotter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public class SerialPlotter extends AbstractMonitor {

private ArrayList<Graph> graphs;
private final static int BUFFER_CAPACITY = 500;
private final static int MAX_GRAPH_COUNT = 20;

private static class Graph {
public CircularBuffer buffer;
Expand Down Expand Up @@ -412,26 +413,26 @@ public void message(final String s) {

int validParts = 0;
int validLabels = 0;
for(int i = 0; i < parts.length; ++i) {
for(int i = 0; i < parts.length && validParts < MAX_GRAPH_COUNT; ++i) {
Double value = null;
String label = null;

// column formated name value pair
if(parts[i].contains(":")) {
// get label
String[] subString = parts[i].split("[:]+");

if(subString.length > 0) {
int labelLength = subString[0].length();

if(labelLength > 32) {
labelLength = 32;
}
label = subString[0].substring(0, labelLength);
} else {
label = "";
}

if(subString.length > 1) {
parts[i] = subString[1];
} else {
Expand All @@ -448,7 +449,7 @@ public void message(final String s) {
if(label == null && value == null) {
label = parts[i];
}

if(value != null) {
if(validParts >= graphs.size()) {
graphs.add(new Graph(validParts));
Expand Down