Skip to content

Add Nicla Sense ME dashboard #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 21, 2022
Merged

Conversation

marqdevx
Copy link
Member

@marqdevx marqdevx commented Nov 8, 2021

In this PR I've:

  • Added inclusion of the Nicla Sense ME board (sketch)
    • Change UUID
    • Add new sensors
    • Add callback on disconnection so the LED will turn red automatically.
  • Changed the style of the "new" dashboard
    • Add Arduino PRO logo
    • Change widget sizes, now there will be no weird spacings
    • Add snackbar with info at the top, user can remove the snackbar notification
    • Change the Pair button with the "PRO colors"
    • The board as it is smaller, the 3d preview camera is closer to the 3d model
    • Rotation of the 3D board is done with quaternions from the device
  • Inside the Readme added the "new" dashboard, and linked a small tutorial explaining how to use Nicla's dashboard

Preview available at https://marqdevx.github.io/ArduinoAI/NiclaSenseME-dashboard/

@marqdevx marqdevx force-pushed the marqdevx/NiclaSenseMe branch from 3c64ad6 to 0995bfb Compare November 22, 2021 17:28
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2021

CLA assistant check
All committers have signed the CLA.

Co-authored-by: TugrulhanEktuna <t.ektuna@arduino.cc>
Co-authored-by: Ftroya <f.troya@arduino.cc>
Co-authored-by: marqdevx <p.marquinez@arduino.cc>
@marqdevx marqdevx force-pushed the marqdevx/NiclaSenseMe branch from 0995bfb to f6ee232 Compare November 22, 2021 17:35
@marqdevx marqdevx marked this pull request as ready for review November 25, 2021 15:23
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things left to do. Please have a look at the comments.

@sebromero
Copy link
Contributor

@marqdevx

  • For me the LED color on the board doesn't match the color on the board.
  • The LED color is not in sync when the app is loaded
  • The LED light source comes from a weird place, should be the thing next to the reset button (see image)
  • I suggest to add a background color to the 3D canvas. E.g. #58585A otherwise it's really hard to see.
    download (2)
    .

@marqdevx
Copy link
Member Author

@marqdevx

* For me the LED color on the board doesn't match the color on the board.

* The LED color is not in sync when the app is loaded

* The LED light source comes from a weird place, should be the thing next to the reset button (see image)

* I suggest to add a background color to the 3D canvas. E.g. #58585A otherwise it's really hard to see.
  ![download (2)](https://user-images.githubusercontent.com/1326220/148982258-7293b562-337f-46b5-a2a6-c37074bff282.png)
  .
  • For the LED sync: Please check if you have the latest BHY2 library version, they changed the gbr to rgb.
  • When the sketch is loaded the board is green, then if you change the Color selector it will apply the selected color to the board
  • I will try to fix the light origin
  • I'll try that color for the background

@marqdevx
Copy link
Member Author

marqdevx commented Jan 12, 2022

@sebromero
Everything added/fixed

New stuff:

  • Now the dashboard will appear with the LED on green.
  • On connect, the LED will be blue (both color picker and the device)
  • When the device gets disconnected, the LED will turn red (both web dashboard and the board)
  • Camera is closer to the board (as it is smaller than the Nano BLE Sense)

image

Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the button. "Nicla" is the name of a whole product family so I'd try to avoid using it.

marqdevx and others added 3 commits January 20, 2022 22:26
From suggestions

Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
@mbanzi mbanzi merged commit 5b8d062 into arduino:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants