Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow HardwareI2C::requestFrom to return values > 256 #132

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Dec 10, 2020

Changing return type of requestFrom from uint8_t to size_t allows the function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it).

Merging this PR also requires to merge

@facchinm Let's coordinate to get this done.

…he function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it.
@aentinger aentinger self-assigned this Dec 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #132 (a553558) into master (4bd75df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          14       14           
  Lines         835      835           
=======================================
  Hits          805      805           
  Misses         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd75df...a553558. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants