Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino String/Stream add features #201

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

PiotrekB416
Copy link
Contributor

@PiotrekB416 PiotrekB416 commented Sep 1, 2023

Add features to Arduino::String and Arduino::Stream
[x] String.insert
[x] Stream.readln or Stream.readLine

Requested by #152
More ideas are welcome

@PiotrekB416 PiotrekB416 marked this pull request as ready for review September 2, 2023 10:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (65633ce) 95.53% compared to head (b9ef2e8) 95.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   95.53%   95.50%   -0.03%     
==========================================
  Files          16       16              
  Lines        1075     1091      +16     
==========================================
+ Hits         1027     1042      +15     
- Misses         48       49       +1     
Files Coverage Δ
api/Stream.h 100.00% <ø> (ø)
api/String.cpp 97.33% <100.00%> (+0.05%) ⬆️
api/String.h 90.90% <100.00%> (+0.90%) ⬆️
api/Stream.cpp 90.00% <83.33%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/String.h Outdated Show resolved Hide resolved
@PiotrekB416 PiotrekB416 changed the title Arduino String add features Arduino String/Stream add features Oct 1, 2023
api/Stream.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants