Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add test case for CanMsgRingBuffer. #207

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jboynes
Copy link
Contributor

@jboynes jboynes commented Sep 7, 2023

Fixes a deprecated use of volatile in CanMsgRingbuffer.
Also added a basic testcase to make sure the CPP file is compiled/tested.

Relies on PR #206 to reliably run the tests under C++20

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09% ⚠️

Comparison is base (ebe1fab) 95.61% compared to head (1765628) 95.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   95.61%   95.52%   -0.09%     
==========================================
  Files          14       16       +2     
  Lines        1048     1072      +24     
==========================================
+ Hits         1002     1024      +22     
- Misses         46       48       +2     
Files Changed Coverage Δ
api/CanMsgRingbuffer.cpp 89.47% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@per1234 per1234 added the bug label Sep 7, 2023
@aentinger aentinger changed the title Fix CanMsgRingbuffer volatile Fix: add test case for CanMsgRingBuffer. Sep 8, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any change pertaining volatile (unless you refer to the change of unary increment/decrement operators to a binary arithmetic operation), but I do appreciate adding the test case.

@aentinger aentinger merged commit f77c4b5 into arduino:master Sep 8, 2023
2 checks passed
@jboynes jboynes deleted the fix_canmsg_volatile branch September 8, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants