Jira-364 Rename EDU to Arduino 101 #52

bbaltz505 · 2015-10-13T22:47:27Z

Updated all references to 'edu' and 'Atlas Edge' in corelibs files. Verified i could compile and upload a sketch on Windows. This requires another change in intel-arduino-tools (PRs 29, 30, 31 and 32)

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

bbaltz505 · 2015-10-13T23:12:46Z

@manoelramonintel please review. Do you know where CONFIG_BOARD_EDU_EMU is used from system/libarc32_edu/framework/include/platform.h?
-#ifdef CONFIG_BOARD_ATLASPEAK_EMU
+#ifdef CONFIG_BOARD_ARDUINO101_EMU

manoelramonintel · 2015-10-14T00:43:12Z

system/libarc32_arduino101/framework/include/platform.h

@@ -111,7 +111,7 @@ struct platform_shared_block_ {
    struct cdc_acm_shared_data	* cdc_acm_buffers;
 };

-#ifdef CONFIG_BOARD_ATLASPEAK_EMU
+#ifdef CONFIG_BOARD_ARDUINO101_EMU
 #define RAM_START           0xffb00000


why are you renaming Atlas Peak EMU to Arduino101 EMU ? EMU is the emulator used for Atlas Peak development like our BT team is using. I do not think this definition must be renamed. Please, keep this comment to other locations of the code

This source code is released as part of the corelibs package so all occurrences of 'EDU' and 'Atlas*' must be removed/replaced. Is this section of code used anymore since it is for an emulator? Can it be removed?

Nope.. Atlas Peak and Atlas Edge are different things. I understand it is the corelibs but part of this code came from platform (including the drivers). Atlas Peak is the platform name which might have the Atlas Peak EMU for debugging and development. I am not sure if Atlas Peak must be renamed.

All internal codenames must be renamed - it's a release requirement from Legal. I was actually replacing AtlasEdge everywhere and replaced this by mistake but it would need to be replaced as well according to their policy. I'll check with Larry on how to handle this. This is a weird one.

ok. Just keep this in mind. Atlaspeak and AtlasEdge are different things in the code. AtlasEdge might be renamed but Atlaspeak is the platform name.

Ah, yes. I see what you're saying now.
AtlasEdge=Arduino101
AtlasPeak=???

exactly. I believe they will ask you to keep atlaspeak, but just confirm it.

Larry said to use QUARK.

bbaltz505 · 2015-10-14T01:51:35Z

@Dan-Emutex Please note the renaming of all codename occurrences of 'EDU' and 'AtlasEdge'

bbaltz505 · 2015-10-14T20:17:23Z

@manoelramonintel Larry said to use 'QUARK' instead of 'ATLASPEAK'. There is no equivalent to CONFIG_BOARD_ATLASPEAK_ in the firmware. The closest I could find was CONFIG_BOARD_CURIE_ .

intel-larry · 2015-10-14T20:21:37Z

Hey guys, I'm trying to catch up. So what is the issue here? The AtlasPeak is the SoC inside of the Curie module. I think the thing in question is the naming of the AtlasPeak Emulation board - which is an internal project. Can we go look at the same file in the Thunderdome V1 beta (where this file actually originates from) and use the naming convention there?

intel-larry · 2015-10-14T20:34:22Z

I grep'd the entire Arduino directory for CONFIG_BOARD_ATLASPEAK_EMU and the only occurrence is in this file. Are these values actually used to build the pre-built library or anywhere else?

manoelramonintel · 2015-10-14T20:35:41Z

@intel-larry AtlasPeak EMU is used to emulate the platform using QEMU (under linux). I just want to make sure if this code be merged to the main line again, we will not impact the emulator.

intel-larry · 2015-10-14T20:38:10Z

I grep'd thunderdome and I don't see it there either. It is likely we can just remove this and the "ifdef". The arc lib is only for Arduino support. I don't think we've ever run any of the Arduino sketches in qemu.

manoelramonintel · 2015-10-14T20:41:01Z

the qemu is being used by the platform teams. If the change proposed does not impact so I am fine with any name or simply removal of the code.

bbaltz505 · 2015-10-14T20:42:35Z

@manoelramonintel let me remove the #ifdef code and ping you for review.
Also, I built several sketches with the pre-compiled library with no issue. Let me verify the BAT tests run successfully still though.

intel-larry · 2015-10-14T20:43:43Z

I don't hink this will ever be upstreamed. So let's just remove it and replace the all the "ifdef" "else" logic.

#ifdef CONFIG_BOARD_ATLASPEAK_EMU
#define RAM_START 0xffb00000
#else
#define RAM_START 0xA8000000
#endif

Becomes:

#define RAM_START 0xA8000000

From: manoelramonintel <notifications@github.com mailto:notifications@github.com>
Reply-To: 01org/corelibs-arduino101 <reply@reply.github.com mailto:reply@reply.github.com>
Date: Wednesday, October 14, 2015 at 1:41 PM
To: 01org/corelibs-arduino101 <corelibs-arduino101@noreply.github.com mailto:corelibs-arduino101@noreply.github.com>
Cc: Larry Barras <larry.barras@intel.com mailto:larry.barras@intel.com>
Subject: Re: [corelibs-arduino101] ATLEDGE-364 Rename EDU to Arduino 101 (#52)

the qemu being used by the platform teams. If the change proposed there is no impact so I am fine with any name or simply removal of the code.

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-148191369.

manoelramonintel · 2015-10-14T20:44:00Z

@bbaltz505 no problem. Thanks! you are not suppose to have any problem with sketches. My concern was only qemu if in the future we merge this code back. Go ahead !

bbaltz505 · 2015-10-14T20:45:41Z

@manoelramonintel I'm more concerned that the extensive renaming throughout the code and platform config files (*.txt) and new, pre-compiled library didn't break something.

manoelramonintel · 2015-10-14T20:47:50Z

@bbaltz505 I think we are fine with these files.. let's merge and test again. I am glad the recompilation of library was done without problems because we were receiving the .a from emutex instead to compile in home (this was the only reason I asked :) )

intel-larry · 2015-10-14T20:48:13Z

A valid concern.

We just have to be careful, change things, test, change things, test and be judicious and methodical about it.

From: Brian Baltz <notifications@github.com mailto:notifications@github.com>
Reply-To: 01org/corelibs-arduino101 <reply@reply.github.com mailto:reply@reply.github.com>
Date: Wednesday, October 14, 2015 at 1:45 PM
To: 01org/corelibs-arduino101 <corelibs-arduino101@noreply.github.com mailto:corelibs-arduino101@noreply.github.com>
Cc: Larry Barras <larry.barras@intel.com mailto:larry.barras@intel.com>
Subject: Re: [corelibs-arduino101] ATLEDGE-364 Rename EDU to Arduino 101 (#52)

@manoelramonintelhttps://github.com/manoelramonintel I'm more concerned that the extensive renaming throughout the code and platform config files (*.txt) and new, pre-compiled library didn't break something.

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/52#issuecomment-148193187.

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

bbaltz505 · 2015-10-14T22:02:13Z

@manoelramonintel I removed CONFIG_BOARD_ATLASPEAK_EMU ifdef section and rebuilt pre-compiled library. Ran the API BAT test with no issues.

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

ATLEDGE-364 Rename EDU to Arduino 101

bbaltz505 force-pushed the arduino101-rename branch from f6ce7f5 to 540487e Compare October 13, 2015 23:03

Brian Baltz added 2 commits October 13, 2015 16:04

ATLEDGE-364 Rename EDU to Arduino 101

d7617ab

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

ATLEDGE-364 Rename EDU library folders

4c04540

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

bbaltz505 force-pushed the arduino101-rename branch from 540487e to 5ccba47 Compare October 13, 2015 23:11

manoelramonintel reviewed Oct 14, 2015
View reviewed changes

bbaltz505 force-pushed the arduino101-rename branch from 92dc3d9 to c36361f Compare October 14, 2015 20:55

Brian Baltz added 2 commits October 14, 2015 14:55

ATLEDGE-364 Remove CONFIG_BOARD_ATLASPEAK_EMU specific code

d342223

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

Update pre-compiled library

570a904

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

bbaltz505 force-pushed the arduino101-rename branch from c36361f to 570a904 Compare October 14, 2015 21:57

ATLEDGE-364 Rename arduino_101_x to arduino_101

c5e9152

Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>

bbaltz505 pushed a commit that referenced this pull request Oct 14, 2015

Merge pull request #52 from 01org/arduino101-rename

7052d8f

ATLEDGE-364 Rename EDU to Arduino 101

bbaltz505 merged commit 7052d8f into master Oct 14, 2015

bbaltz505 deleted the arduino101-rename branch October 16, 2015 22:53

kitsunami changed the title ~~ATLEDGE-364 Rename EDU to Arduino 101~~ Jira-364 Rename EDU to Arduino 101 Mar 3, 2016

Uh oh!

Jira-364 Rename EDU to Arduino 101 #52

Jira-364 Rename EDU to Arduino 101 #52

Uh oh!

Conversation

bbaltz505 commented Oct 13, 2015

Uh oh!

bbaltz505 commented Oct 13, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbaltz505 commented Oct 14, 2015

Uh oh!

bbaltz505 commented Oct 14, 2015

Uh oh!

intel-larry commented Oct 14, 2015

Uh oh!

intel-larry commented Oct 14, 2015

Uh oh!

manoelramonintel commented Oct 14, 2015

Uh oh!

intel-larry commented Oct 14, 2015

Uh oh!

manoelramonintel commented Oct 14, 2015

Uh oh!

bbaltz505 commented Oct 14, 2015

Uh oh!

intel-larry commented Oct 14, 2015

Uh oh!

manoelramonintel commented Oct 14, 2015

Uh oh!

bbaltz505 commented Oct 14, 2015

Uh oh!

manoelramonintel commented Oct 14, 2015

Uh oh!

intel-larry commented Oct 14, 2015

Uh oh!

bbaltz505 commented Oct 14, 2015

Uh oh!

Uh oh!