Skip to content

nicla: Add missing return value in enterShipMode function. #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nicla: Add missing return value in enterShipMode function. #657

wants to merge 1 commit into from

Conversation

sebromero
Copy link
Collaborator

@sebromero sebromero commented Apr 7, 2023 •
edited
Loading

An alternative solution to #635 which adds a missing return statement that leads to a compiler warning.

Thank you @alessandromrc for spotting this!

@sebromero sebromero requested a review from alrvid April 18, 2023 13:23
alrvid
alrvid approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@alrvid alrvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)

@sebromero sebromero closed this May 17, 2023
@sebromero sebromero deleted the sebromero/nicla-shipmode-fix branch May 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alrvid alrvid alrvid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @alrvid