Skip to content

Bugfix - waiting for first ADC read to complete after ADC enable. #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Bugfix - waiting for first ADC read to complete after ADC enable. #447

merged 1 commit into from
Sep 3, 2019

Conversation

aentinger
Copy link
Contributor

This PR fixes #446.

@aentinger aentinger mentioned this pull request Sep 3, 2019
Closed
@aentinger aentinger merged commit aef4af4 into master Sep 3, 2019
@aentinger aentinger deleted the analog-read-fix branch September 3, 2019 08:45
@amezins
Copy link

amezins commented Sep 5, 2019

I had a similar problem on an AD674 used in a project over 20 years ago. All clone manufacturers duplicated the problem of the original part that failed to include a HW reset line to initialize the internal registers that weren't reset by the power up cycle. I "fixed" it by adding a dummy conversion start command to the ADC driver's power up initialization. Each of my drivers had a vector for power up initialization that were enumerated by the "main" power up initialization for the drivers.

@Muplex
Copy link

Muplex commented Oct 4, 2019

Hello,
I have last build installed 1.8.3 but these bug still happend.
I measure 30 to 40 steps (12 bit resolution) when analogpin is grounded (should be near to 0)
Can you explain me how to fix it ?

Thank you

@aentinger
Copy link
Contributor Author

aentinger commented Oct 7, 2019 •
edited
Loading

That's because no new version (next would be 1.8.4) containing the fix has been released yet. @facchinm What do you think about releasing 1.8.4?

@facchinm
Copy link
Member

facchinm commented Oct 7, 2019

@lxrobotics today or tomorrow 😉

tuniii added a commit to tuniii/platformio-pkg-framework-arduinosam that referenced this pull request Jan 12, 2020
@tuniii
Bugfix - waiting for first ADC read to complete after ADC enable.
da35849 
arduino/ArduinoCore-samd#447
@bobd13 bobd13 mentioned this pull request Jan 13, 2020
Open
@akerr501 akerr501 mentioned this pull request Sep 2, 2020
Closed
@GaudiLabs GaudiLabs mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@sandeepmistry sandeepmistry Awaiting requested review from sandeepmistry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analogRead() provides incorrect results on the SAMD21 core.
5 participants
@aentinger @amezins @Muplex @facchinm @cmaglie