Don't use RESET_N pin #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data sheet discourages use of SARA modem reset pin, use may lead to irrecoverable state of modem
|
@aentinger Here is the change we discussed |
aentinger
requested changes
Jul 23, 2020
| pinMode(SARA_RESETN, OUTPUT); | ||
| digitalWrite(SARA_RESETN, HIGH); | ||
| digitalWrite(SARA_RESETN, LOW); |
There was a problem hiding this comment.
Hi @janakelarsson 👋 This line is already in ArduinoCore-samd:master:HEAD - please rebase your commit.
There was a problem hiding this comment.
@aentinger Better now (I don't have a local copy of the git archive for that small change so I mistakenly thought the green light meant the PR was OK)?
There was a problem hiding this comment.
Or do I need to squash the commits?
There was a problem hiding this comment.
Good now, I'll squash them myself.
Update to arduino master
Update from master
aentinger
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change comment: Data sheet discourages use of SARA modem reset pin, use may lead to irrecoverable state of modem