Skip to content

Make SerialCDC inherit from HardwareSerial #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Make SerialCDC inherit from HardwareSerial #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/arduino/USB/CDC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ void Serial_::begin(uint32_t /* baud_count */)
// uart config is ignored in USB-CDC
}

void Serial_::begin(uint32_t /* baud_count */, uint8_t /* config */)
void Serial_::begin(uint32_t /* baud_count */, uint16_t /* config */)
{
// uart config is ignored in USB-CDC
}
Expand Down
5 changes: 3 additions & 2 deletions cores/arduino/USB/USBAPI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "Arduino.h"
#include "api/Stream.h"
#include "api/RingBuffer.h"
#include "api/HardwareSerial.h"
#include "api/USBAPI.h"
#include "CDC.h"

Expand Down Expand Up @@ -96,12 +97,12 @@ extern USBDeviceClass USBDevice;
//================================================================================
// Serial over CDC (Serial1 is the physical port)

class Serial_ : public arduino::Stream, public arduino::PluggableUSBModule
class Serial_ : public arduino::HardwareSerial, arduino::PluggableUSBModule
{
public:
Serial_(USBDeviceClass &_usb);
void begin(uint32_t baud_count);
void begin(unsigned long, uint8_t);
void begin(unsigned long, uint16_t);
void end(void);

virtual int available(void);
Expand Down