Skip to content

Fixed Serial_::begin(..) definition to match arduino::HardwareSerial #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fixed Serial_::begin(..) definition to match arduino::HardwareSerial #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cores/arduino/USB/CDC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ void Serial_::enableInterrupt() {
usbd.epBank0EnableTransferComplete(CDC_ENDPOINT_OUT);
}

void Serial_::begin(uint32_t /* baud_count */)
void Serial_::begin(unsigned long /* baudrate */)
{
// uart config is ignored in USB-CDC
}

void Serial_::begin(uint32_t /* baud_count */, uint16_t /* config */)
void Serial_::begin(unsigned long /* baudrate */, uint16_t /* config */)
{
// uart config is ignored in USB-CDC
}
Expand Down
4 changes: 2 additions & 2 deletions cores/arduino/USB/USBAPI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class Serial_ : public arduino::HardwareSerial, arduino::PluggableUSBModule
{
public:
Serial_(USBDeviceClass &_usb);
void begin(uint32_t baud_count);
void begin(unsigned long, uint16_t);
void begin(unsigned long baudrate);
void begin(unsigned long baudrate, uint16_t config);
void end(void);

virtual int available(void);
Expand Down