Added integration test for lib-discovery-caching

Author: cmaglie

internal/integrationtest/compile_4/lib_discovery_caching_test.go

@@ -28,18 +28,66 @@ func TestLibDiscoveryCache(t *testing.T) {
 	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
 	t.Cleanup(env.CleanUp)
 
-	// Install Arduino AVR Boards
-	_, _, err := cli.Run("core", "install", "arduino:avr@1.8.6")
-	require.NoError(t, err)
-
 	// Copy the testdata sketchbook
 	testdata, err := paths.New("testdata", "libraries_discovery_caching").Abs()
 	require.NoError(t, err)
 	sketchbook := cli.SketchbookDir()
 	require.NoError(t, sketchbook.RemoveAll())
 	require.NoError(t, testdata.CopyDirTo(cli.SketchbookDir()))
 
-	t.Run("BasicLibDiscovery", func(t *testing.T) {
+	// Install Arduino AVR Boards
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.6")
+	require.NoError(t, err)
+	// Install Ethernet library
+	_, _, err = cli.Run("lib", "install", "Ethernet")
+	require.NoError(t, err)
+
+	t.Run("RemoveLibWithoutError", func(t *testing.T) {
+		sketchA := sketchbook.Join("SketchA")
+		buildpath, err := sketchA.Join("build").Abs()
+		require.NoError(t, err)
+		t.Cleanup(func() { buildpath.RemoveAll() })
+
+		{
+			require.NoError(t, sketchA.Join("SketchA.ino").WriteFile([]byte(`
+#include <SPI.h>
+#include <Ethernet.h>
+void setup() {}
+void loop() {}`)))
+			outjson, _, err := cli.Run("compile", "-v", "-b", "arduino:avr:uno", "--build-path", buildpath.String(), "--json", sketchA.String())
+			require.NoError(t, err)
+			j := requirejson.Parse(t, outjson)
+			usedLibs := j.Query("[.builder_result.used_libraries[].name]")
+			usedLibs.MustEqual(`["SPI", "Ethernet"]`)
+		}
+
+		{
+			// Update SketchA
+			require.NoError(t, sketchA.Join("SketchA.ino").WriteFile([]byte(`
+#include <SPI.h>
+void setup() {}
+void loop() {}`)))
+			// This compile should not include Ethernet
+			outjson, _, err := cli.Run("compile", "-v", "-b", "arduino:avr:uno", "--build-path", buildpath.String(), "--json", sketchA.String())
+			require.NoError(t, err)
+			j := requirejson.Parse(t, outjson)
+			usedLibs := j.Query("[.builder_result.used_libraries[].name]")
+			usedLibs.MustEqual(`["SPI"]`)
+			j.Query(".compiler_out").MustContain(`"The list of included libraries has been changed... rebuilding all libraries."`)
+		}
+
+		{
+			// This compile should not rebuild libs
+			outjson, _, err := cli.Run("compile", "-v", "-b", "arduino:avr:uno", "--build-path", buildpath.String(), "--json", sketchA.String())
+			require.NoError(t, err)
+			j := requirejson.Parse(t, outjson)
+			usedLibs := j.Query("[.builder_result.used_libraries[].name]")
+			usedLibs.MustEqual(`["SPI"]`)
+			j.Query(".compiler_out").MustNotContain(`"The list of included libraries has changed... rebuilding all libraries."`)
+		}
+	})
+
+	t.Run("RemoveLibWithError", func(t *testing.T) {
 		sketchA := sketchbook.Join("SketchA")
 		buildpath, err := sketchA.Join("build").Abs()
 		require.NoError(t, err)