add git library imports

have added a --git-url flag to lib install
takes the git url and extracts it to the libraries directory

Author: vinay-lanka

arduino/libraries/librariesmanager/install.go

@@ -20,7 +20,6 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"log"
 	"os"
 	"path/filepath"
 	"strings"
@@ -29,6 +28,7 @@ import (
 	"github.com/arduino/arduino-cli/arduino/libraries/librariesindex"
 	"github.com/arduino/arduino-cli/arduino/utils"
 	paths "github.com/arduino/go-paths-helper"
+	"gopkg.in/src-d/go-git.v4"
 )
 
 var (
@@ -100,7 +100,7 @@ func (lm *LibrariesManager) InstallZipLib(libPath string) error {
 	}
 	err := Unzip(libPath, libsDir.String())
 	if err != nil {
-		log.Fatal(err)
+		return err
 	}
 	return nil
 }
@@ -161,3 +161,29 @@ func Unzip(src string, dest string) error {
 	}
 	return nil
 }
+
+//InstallGitLib  installs a library hosted on a git repository on the specified path.
+func (lm *LibrariesManager) InstallGitLib(Name string, gitURL string) error {
+	libsDir := lm.getUserLibrariesDir()
+	if libsDir == nil {
+		return fmt.Errorf("User directory not set")
+	}
+	err := Fetch(Name, gitURL, libsDir.String())
+	if err != nil {
+		return err
+	}
+	return nil
+}
+
+//Fetch Clones the repository to LibsDir
+func Fetch(name string, url string, dest string) error {
+	directory := dest + "/" + name
+	_, err := git.PlainClone(directory, false, &git.CloneOptions{
+		URL:               url,
+		RecurseSubmodules: git.DefaultSubmoduleRecursionDepth,
+	})
+	if err != nil {
+		return err
+	}
+	return nil
+}

cli/lib/install.go

@@ -57,14 +57,25 @@ func runInstallCommand(cmd *cobra.Command, args []string) {
 	if installFlags.zipPath != "" {
 		ZiplibraryInstallReq := &rpc.ZipLibraryInstallReq{
 			Instance: instance,
-			Path: installFlags.zipPath,
+			Path:     installFlags.zipPath,
 		}
 		_, err := lib.ZipLibraryInstall(context.Background(), ZiplibraryInstallReq)
 		if err != nil {
 			feedback.Errorf("Error installing Zip Library %v", err)
 			os.Exit(errorcodes.ErrGeneric)
 		}
-	}else{
+	} else if installFlags.gitURL != "" {
+		GitlibraryInstallReq := &rpc.GitLibraryInstallReq{
+			Instance: instance,
+			Name:     args[0],
+			Url:      installFlags.gitURL,
+		}
+		_, err := lib.GitLibraryInstall(context.Background(), GitlibraryInstallReq)
+		if err != nil {
+			feedback.Errorf("Error installing Git Library %v", err)
+			os.Exit(errorcodes.ErrGeneric)
+		}
+	} else {
 		libRefs, err := ParseLibraryReferenceArgsAndAdjustCase(instance, args)
 		if err != nil {
 			feedback.Errorf("Arguments error: %v", err)

commands/daemon/daemon.go

@@ -292,3 +292,8 @@ func (s *ArduinoCoreServerImpl) LibraryList(ctx context.Context, req *rpc.Librar
 func (s *ArduinoCoreServerImpl) ZipLibraryInstall(ctx context.Context, req *rpc.ZipLibraryInstallReq) (*rpc.ZipLibraryInstallResp, error) {
 	return lib.ZipLibraryInstall(ctx, req)
 }
+
+//GitLibraryInstall FIXMEDOC
+func (s *ArduinoCoreServerImpl) GitLibraryInstall(ctx context.Context, req *rpc.GitLibraryInstallReq) (*rpc.GitLibraryInstallResp, error) {
+	return lib.GitLibraryInstall(ctx, req)
+}

commands/lib/install.go

@@ -96,3 +96,24 @@ func installZipLibrary(lm *librariesmanager.LibrariesManager, libPath string) er
 	}
 	return nil
 }
+
+//GitLibraryInstall FIXMEDOC
+func GitLibraryInstall(ctx context.Context, req *rpc.GitLibraryInstallReq) (*rpc.GitLibraryInstallResp, error) {
+	res := &rpc.GitLibraryInstallResp{}
+	lm := commands.GetLibraryManager(req.GetInstance().GetId())
+	URL := req.GetUrl()
+	Name := req.GetName()
+	if err := installGitLibrary(lm, Name, URL); err != nil {
+		res.Status = "Error installing Git Library"
+		return res, err
+	}
+	res.Status = "Success! Installed Git Library"
+	return res, nil
+}
+
+func installGitLibrary(lm *librariesmanager.LibrariesManager, Name string, gitURL string) error {
+	if err := lm.InstallGitLib(Name, gitURL); err != nil {
+		return err
+	}
+	return nil
+}

go.mod

@@ -23,15 +23,19 @@ require (
 	github.com/juju/errors v0.0.0-20181118221551-089d3ea4e4d5 // indirect
 	github.com/juju/loggo v0.0.0-20190526231331-6e530bcce5d8 // indirect
 	github.com/juju/testing v0.0.0-20190429233213-dfc56b8c09fc // indirect
+	github.com/kr/pretty v0.2.0 // indirect
+	github.com/kr/text v0.2.0 // indirect
 	github.com/mattn/go-colorable v0.1.2
 	github.com/mattn/go-runewidth v0.0.2 // indirect
 	github.com/miekg/dns v1.0.5 // indirect
+	github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
 	github.com/oleksandr/bonjour v0.0.0-20160508152359-5dcf00d8b228 // indirect
 	github.com/pkg/errors v0.9.1
 	github.com/pmylund/sortutil v0.0.0-20120526081524-abeda66eb583
 	github.com/rifflock/lfshook v0.0.0-20180920164130-b9218ef580f5
 	github.com/schollz/closestmatch v2.1.0+incompatible
 	github.com/segmentio/stats/v4 v4.5.3
+	github.com/sergi/go-diff v1.1.0 // indirect
 	github.com/sirupsen/logrus v1.4.2
 	github.com/spf13/cobra v0.0.5
 	github.com/spf13/jwalterweatherman v1.0.0
@@ -42,12 +46,14 @@ require (
 	go.bug.st/relaxed-semver v0.0.0-20190922224835-391e10178d18
 	go.bug.st/serial v1.0.0
 	go.bug.st/serial.v1 v0.0.0-20180827123349-5f7892a7bb45 // indirect
-	golang.org/x/net v0.0.0-20200202094626-16171245cfb2
-	golang.org/x/sys v0.0.0-20200202164722-d101bd2416d5 // indirect
+	golang.org/x/crypto v0.0.0-20200406173513-056763e48d71 // indirect
+	golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e
+	golang.org/x/sys v0.0.0-20200408040146-ea54a3c99b9b // indirect
 	golang.org/x/text v0.3.2
 	google.golang.org/genproto v0.0.0-20200204135345-fa8e72b47b90 // indirect
 	google.golang.org/grpc v1.27.0
-	gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect
+	gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f // indirect
 	gopkg.in/mgo.v2 v2.0.0-20180705113604-9856a29383ce // indirect
+	gopkg.in/src-d/go-git.v4 v4.13.1
 	gopkg.in/yaml.v2 v2.2.4
 )