always warn the user about deprecated pde files

Author: umbynos

cli/arguments/sketch.go

@@ -45,20 +45,17 @@ func InitSketchPath(sketchPath string) *paths.Path {
 
 // SketchPathCalculation returns the path and instance of the sketch and the discovery port.
 // Optionally, it warns the user when the sketch contains .pde files.
-func SketchPathCalculation(path string, port Port, instance *rpc.Instance, warn bool) (*paths.Path, *sketch.Sketch, *discovery.Port) {
-	sketchPath := InitSketch(path, warn)
+func SketchPathCalculation(path string, port Port, instance *rpc.Instance) (*paths.Path, *sketch.Sketch, *discovery.Port) {
+	sketchPath := InitSketch(path)
 	sketch := CreateSketch(sketchPath)
 	discoveryPort := GetDiscoveryPort(instance, port, sketch)
 	return sketchPath, sketch, discoveryPort
 }
 
 // InitSketch is a helper function that determines the sketch path. Optionally, it warns the user when the sketch contains .pde files.
-func InitSketch(path string, warn bool) *paths.Path {
+func InitSketch(path string) *paths.Path {
 	sketchPath := InitSketchPath(path)
-
-	if warn {
-		WarnDeprecatedFiles(sketchPath)
-	}
+	WarnDeprecatedFiles(sketchPath)
 	return sketchPath
 }
 

cli/compile/compile.go

@@ -131,7 +131,7 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
 		path = args[0]
 	}
 
-	sketchPath := arguments.InitSketch(path, true)
+	sketchPath := arguments.InitSketch(path)
 
 	var overrides map[string]string
 	if sourceOverrides != "" {

cli/debug/debug.go

@@ -74,7 +74,7 @@ func runDebugCommand(command *cobra.Command, args []string) {
 	if len(args) > 0 {
 		path = args[0]
 	}
-	sketchPath, _, discoveryPort := arguments.SketchPathCalculation(path, port, instance, false)
+	sketchPath, _, discoveryPort := arguments.SketchPathCalculation(path, port, instance)
 	debugConfigRequested := &dbg.DebugConfigRequest{
 		Instance:    instance,
 		Fqbn:        fqbn.String(),

cli/upload/upload.go

@@ -76,7 +76,7 @@ func runUploadCommand(command *cobra.Command, args []string) {
 	if len(args) > 0 {
 		path = args[0]
 	}
-	sketchPath, sk, discoveryPort := arguments.SketchPathCalculation(path, port, instance, true)
+	sketchPath, sk, discoveryPort := arguments.SketchPathCalculation(path, port, instance)
 
 	if fqbn.String() == "" && sk != nil && sk.Metadata != nil {
 		// If the user didn't specify an FQBN and a sketch.json file is present