Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downloading index and signature in a single tar.bz2 archive #1734

Merged
merged 8 commits into from
May 24, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 17, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Allow downloading index and signature in a single tar.bz2 archive

Does this PR introduce a breaking change, and is titled accordingly?
No

@per1234 per1234 added the topic: code Related to content of the project itself label May 17, 2022
arduino/resources/index.go Outdated Show resolved Hide resolved
arduino/resources/index.go Outdated Show resolved Hide resolved
arduino/resources/index.go Outdated Show resolved Hide resolved
arduino/resources/index.go Outdated Show resolved Hide resolved
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions/suggestions

@umbynos
Copy link
Contributor

umbynos commented May 19, 2022

Nice work 🥇

@cmaglie cmaglie force-pushed the signature_archive branch 2 times, most recently from b1e25f3 to e4b1ec0 Compare May 20, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants