Skip to content

Conversation

csarnataro
Copy link
Collaborator

With some boards (namely ESP32 S3 Dev Kit) the command line coming from the Arduino compute endpoint contains more occurrences of {build.project_name}, e.g. something like {build.project_name}.bootloader.bin [...] {build.project_name}.bin.
In order to support these boards, we have to pick (by convention) the last occurrence, since it's what we use internally to retrieve the right file extension (in this case bin). Otherwise, in the example above, the file extension will be boo from .bootloader.

NOTE: we could even improve this logic using a simple regular expression, something like \{build\.project_name\}\.(\w\w\w)\b, and then extract the extension which matches (\w\w\w)

@csarnataro csarnataro requested a review from rsora August 17, 2022 10:37
@csarnataro csarnataro marked this pull request as ready for review September 6, 2022 13:14
@csarnataro csarnataro merged commit 1cb467d into master Sep 6, 2022
@csarnataro csarnataro deleted the csarnataro/fix-esp-upload branch September 6, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant