Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io/ioutil since is deprecated #818

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove io/ioutil since is deprecated #818

merged 1 commit into from
Aug 29, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Aug 28, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

remove deprecated package

  • What is the current behavior?

Deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.

  • What is the new behavior?

We use package io or os

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added the topic: code Related to content of the project itself label Aug 28, 2023
@umbynos umbynos self-assigned this Aug 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 42.10% and no project coverage change.

Comparison is base (6c5dfae) 10.83% compared to head (bf55f11) 10.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   10.83%   10.83%           
=======================================
  Files          52       52           
  Lines        4043     4043           
=======================================
  Hits          438      438           
  Misses       3550     3550           
  Partials       55       55           
Flag Coverage Δ
unit 10.83% <42.10%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
conn.go 0.00% <0.00%> (ø)
tools/download.go 30.62% <0.00%> (ø)
tools/tools.go 0.00% <0.00%> (ø)
upload/upload.go 41.15% <0.00%> (ø)
utilities/utilities.go 11.49% <100.00%> (ø)
v2/pkgs/indexes.go 61.29% <100.00%> (ø)
v2/pkgs/tools.go 70.34% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos merged commit cc9a238 into main Aug 29, 2023
56 checks passed
@umbynos umbynos deleted the remove-ioutil branch August 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants