Fix text plain decoding #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is only a cosmetic change
umbynos
added
topic: code
…s of the Web Editor The requests sent uses `text/plain` Content-Type when they should be using `application/json` This commit restores the old behavior, using always a json Decoder
umbynos
force-pushed
the
fix-text-plain-decoding
branch
from
05344f2
to
98fdf66
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 11.14% 16.88% +5.73%
==========================================
Files 53 53
Lines 4073 4075 +2
==========================================
+ Hits 454 688 +234
+ Misses 3563 3287 -276
- Partials 56 100 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bug fix
The frontend for some reason sends requests with "text/plain" content type header. With #815 a new Decoder for that content type was implemented. This breaks the current version of the agent. This needs fixing in the frontend, but nonetheless the change of #815 was a breaking one.
use a CustomRequestDecoder to handle properly the misbehaving requests of the Web Editor
The requests sent uses
text/plainContent-Type when they should be usingapplication/jsonThis commit restores the old behavior, using always a json Decoder
no