bugfix: serial enumerator failures in some rare circumstances #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
+ Coverage 11.14% 16.85% +5.70%
==========================================
Files 53 53
Lines 4073 4082 +9
==========================================
+ Hits 454 688 +234
+ Misses 3563 3294 -269
- Partials 56 100 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
added
topic: code
cmaglie
force-pushed
the
discovery_bug_fix
branch
from
d7962a5
to
decd813
Compare
3 tasks
cmaglie
changed the title
cmaglie
changed the title
umbynos
approved these changes
Sep 14, 2023
umbynos
reviewed
Sep 14, 2023
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
What kind of change does this PR introduce?
What is the current behavior?
If an en enumerator starts failing the current port list is retained. This leads to strange behaviors like #808.
What is the new behavior?
The new behavior is to clean up the port list if the enumerator fails to enumerate the ports.
Does this PR introduce a breaking change?
No
Other information:
This PR contains two fixes:
a workaround for Port is persistently discovered after disconnect #808
an actual fix for the main problem: the enumerator produces the following error with some peculiar hardware setups:
The fix is here: Fix some rare MacOSX USB port enumerator failures bugst/go-serial#165
and
I've also added some refactorings that are not strictly related to this issue but are suitable for future improvements on the agent.