Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in comment update #72

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Conversation

karlsoderby
Copy link
Contributor

All links inside the "Built-in Examples" had links pointing to older tutorials. This PR updates them to point to the docs.arduino.cc hosted tutorials.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency in the forms of the URLs. ~Half have a trailing slash (e.g., https://docs.arduino.cc/built-in-examples/basics/Blink/ and the other half omit the trailing slash (e.g., https://docs.arduino.cc/built-in-examples/basics/Blink).

Although the URL format without the trailing slash works perfectly well, it results in a redirect to the final URL with the trailing slash. Using the final URL is best practices so I suggest using that form consistently.

examples/04.Communication/ASCIITable/ASCIITable.ino Outdated Show resolved Hide resolved
examples/04.Communication/Dimmer/Dimmer.ino Outdated Show resolved Hide resolved
examples/04.Communication/Graph/Graph.ino Outdated Show resolved Hide resolved
examples/04.Communication/Midi/Midi.ino Outdated Show resolved Hide resolved
examples/04.Communication/MultiSerial/MultiSerial.ino Outdated Show resolved Hide resolved
examples/09.USB/Keyboard/KeyboardSerial/KeyboardSerial.ino Outdated Show resolved Hide resolved
examples/08.Strings/StringIndexOf/StringIndexOf.ino Outdated Show resolved Hide resolved
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels Jan 19, 2024
Co-authored-by: per1234 <accounts@perglass.com>
@karlsoderby
Copy link
Contributor Author

Thanks a lot @per1234 for spotting that, all suggestions applied.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karlsoderby!

@per1234 per1234 merged commit 3ad4da8 into arduino:main Jan 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants