Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArduinoISP: Add hint MISO/MOSI -> CIPO/COPI #73

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

fritzlb
Copy link
Contributor

@fritzlb fritzlb commented Mar 11, 2024

The Arduino documentation uses the new CIPO/COPI terminology while the whole arduino core still uses the old MISO/MOSI. While I thought about changing everything in the arduino cores, this would break many old sketches so I figuered adding a hint is the way to go. Also, only changing terminology in this sketch doesn't work for consistency reasons, eg. beginning in line 106.

The Arduino documentation uses the new CIPO/COPI terminology while the whole arduino core still uses the old MISO/MOSI. 
While I thought about changing everything in the arduino cores, this would break many old sketches so I figuered adding a hint is the way to go.
Also, only changing terminology in this sketch doesn't work for consistency reasons, eg. beginning in line 106.
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 11, 2024
@per1234 per1234 self-assigned this Mar 11, 2024
Co-authored-by: per1234 <accounts@perglass.com>
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fritzlb!

@per1234 per1234 merged commit 5d991a2 into arduino:main Mar 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants