Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version subcommand #36

Merged
merged 4 commits into from May 24, 2021
Merged

add version subcommand #36

merged 4 commits into from May 24, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented May 21, 2021 

./FirmwareUploader version
FirmwareUploader Version: git-snapshot Commit: 9e267c9 Date: 2021-05-21T17:16:47Z

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 21, 2021
@umbynos umbynos requested a review from silvanocerza May 21, 2021 17:21
@umbynos umbynos self-assigned this May 21, 2021
silvanocerza
silvanocerza reviewed May 24, 2021
View reviewed changes
cli/cli.go Outdated
@@ -45,10 +46,11 @@ func NewCommand() *cobra.Command {
Short: "FirmwareUploader.",
Long: "FirmwareUploader (FirmwareUploader).",
Example: " " + os.Args[0] + " <command> [flags...]",
Args: cobra.NoArgs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to remove this I think? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I'll reintroduce it

@umbynos umbynos merged commit d2900cb into main May 24, 2021
@umbynos umbynos deleted the umbynos/version branch May 24, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@umbynos @silvanocerza