-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translations #1431
Comments
The equivalent version of Eclipse Theia IDE framework (1.25.0), with the same version of the language pack ( |
Typo in translation keys:
|
The source is the CLI. IDE2 toasts the error message as-is from the CLI. There is a caveat here, IDE2 and CLI language can be configured separately. 🤦 I expect the following is going on:
Thank you for reporting it. |
It's logged here #1431 (comment). |
This can be caused by changes to the names of the internationalization keys in the Arduino IDE codebase. For example, when the typo Akos reported here is fixed in the codebase, the string will go back into an untranslated state on Transifex. Hopefully translation memory can make any re-translations a simple process at least. |
Yes if it is identical, it will automatically filled in! No problem! It's just I cannot find those strings "More" and "Default" aren't' listed anymore inside Transifex. But I could be confused with IDE 2.0 or older IDE1.5 localisation |
For the record, it does not work for me with Theia 1.25.0 and the Chinese language pack manually installed: Update: I have downloaded version |
I have found the cause of why {
"vs/workbench/contrib/notebook/common/model/notebookTextModel": {
"defaultEditLabel": "编辑"
},
} This entry 👆 is available in an older version of the Chinese language pack. Go to https://open-vsx.org/extension/MS-CEINTL/vscode-language-pack-zh-hans/1.53.2, download the VS Code extension, unpack it, and check the file. This entry is unavailable in a more recent version of the Chinese language pack. See for example https://open-vsx.org/extension/MS-CEINTL/vscode-language-pack-zh-hans/1.71.0. "vs/workbench/api/browser/mainThreadCustomEditors": {
"defaultEditLabel": "编辑"
}, In summary, IDE2's Theia version (1.25.0) cannot deal with the newer version of language packs. I see three options:
I will leave the decision to @davegarthsimpson. The rest of the translation issues are fixed. |
Good catch. I somehow missed that the language pack versions had been bumped in the IDE.
Is that even really a guaranteed solution? Theia 1.29.0 is still using VS Code API 1.53.2: https://github.com/eclipse-theia/theia/blob/v1.29.0/dev-packages/application-package/src/api.ts#L21 It seems to me that the only correct approach is to keep language packs synced with the VS Code API version in use. |
Good point. We should probably start a discussion on the Theia forum.
In this case, we have to go back to this commit. The |
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Aligned the languge pack versions. Closes #1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Describe the problem
The following problems were reported by users:
To reproduce
Open 2.0.0 IDE2, and set the language to non-English.
Expected behavior
All text defined by IDE2/Theia must be translated when a translation exists.
Not from the CLI.
Arduino IDE version
2.0.0
Operating system
N/A
Operating system version
n/a
Additional context
Go through the code and add the missing translations.
Keywords
Issue checklist
The text was updated successfully, but these errors were encountered: