fix: falsy context menu handlerId
#2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very first context menu item with ID `0` has not had a click handler Ref: eclipse-theia/theia#12500 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
added
topic: code
per1234
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix the non-functional
New Tabcontent menu item from•••. The first context menu item with ID0has no click handler.Change description
Customized the default Theia menu item building to attach the click handler to the menu node with ID
0Steps to reproduce:
File>New Sketch, orCtrl/Cmd+N),•••,New Tabthe new file dialog opens.Other information
Originally reported here: https://forum.arduino.cc/t/new-tab-command-first-invocation-does-nothing/1160085
Ref: eclipse-theia/theia#12500 (comment)
Reviewer checklist