chore: update electron dependency + Node.js
#2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
type: enhancement
3 tasks
kittaakos
force-pushed
the
update-infra
branch
from
19b49ec
to
ed42b34
Compare
kittaakos
changed the title
electron dependency + Node.js
per1234
previously requested changes
Aug 31, 2023
added 4 commits
September 1, 2023 10:21
narrow the `resources` folder constraint in the .gitignore Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
remove `msvs_version` npm config on win32 Ref: nodejs/node-gyp#2822 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
- Update to `electron-builder@24.6.3`. - Fix obsolete electron security section in the development docs. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
force-pushed
the
update-infra
branch
from
ed42b34
to
62736fa
Compare
kittaakos
commented
Sep 1, 2023
| @@ -1,6 +1,8 @@ | |||
| ### Building and start the app from the sources on Ubuntu Linux | |||
|
|
|||
| Tested and verified on Ubuntu 18.04.4. The source will be checked out to `~/dev/git/arduino-ide`. | |||
| Tested and verified on Ubuntu 22.04. The source will be checked out to `~/dev/git/arduino-ide`. | |||
There was a problem hiding this comment.
Chicken-egg problem: the main still does not support Node.js 18+. Here is what should work. The git checkout part differs
#!/bin/bash -i
sudo apt update \
&& sudo apt install --no-install-recommends --yes \
git \
gcc \
curl \
make \
python3 \
pkg-config \
libx11-dev \
libxkbfile-dev \
build-essential \
libsecret-1-dev \
&& wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash \
&& source ~/.bashrc \
&& nvm install 18.17 \
&& nvm use 18.17 \
&& nvm alias default 18.17 \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list \
&& sudo apt update && sudo apt install --no-install-recommends yarn \
&& mkdir -p ~/dev/git/ \
&& rm -rf ~/dev/git/arduino-ide \
&& git clone https://github.com/arduino/arduino-ide.git ~/dev/git/arduino-ide \
&& git -C ~/dev/git/arduino-ide checkout origin/update-infra -b update-infra \
&& yarn --cwd ~/dev/git/arduino-ide \
&& yarn --cwd ~/dev/git/arduino-ide/electron-app rebuild \
&& yarn --cwd ~/dev/git/arduino-ide build \
&& yarn --cwd ~/dev/git/arduino-ide start
4 tasks
|
Please review. Thank you! |
davegarthsimpson
approved these changes
Sep 14, 2023
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use Node.js 18+ and the latest Electron version for the build and runtime.
Change description
prettierconfig,>=18.17.0,electron@25.5.0Other information
For reviewers:
Reviewer checklist