Save preferences in sequence #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
force-pushed
the
msujew/preference-fixes
branch
from
073578c
to
05ca5fe
Compare
per1234
added
topic: code
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #830
For some reason, you cannot save preferences in parallel. I assume this is due to eclipse-theia/theia#10562, but I'm not 100% sure. I'll create an issue in the Theia repo as well. But for now, this works fairly well.
This also adds an additional guard to the
window.reload()when changing the preferences to not reload the app when thenls.localevariable is undefined (this indicates that the app runs in English).