Add support for version constraints in depends field #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, I have found that using Arduino CLI infrastructure for handling projects is not always the right choice because Arduino CLI is intended to be resilient to sub-ideal project configurations when feasible, whereas Arduino Lint is intended to enforce or encourage ideal project configurations. However, Arduino Lint is not intended to lint the Library Manager index, so using Arduino CLI's code for querying the index should be safe and avoid the problems associated with the code duplication that would be the alternative.
per1234
added
topic: code
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 84.36% 84.41% +0.05%
==========================================
Files 43 43
Lines 2986 3009 +23
==========================================
+ Hits 2519 2540 +21
- Misses 374 375 +1
- Partials 93 94 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Arduino CLI and the Library Manager indexer has some provisional support for specifying version constraints in the library.properties depends field. Although undocumented, this syntax is fully supported by the other tools, so Arduino Lint's previous treatment of libraries using this feature as invalid is incorrect.
The library.properties depends field is used to specify the library dependencies. Although currently undocumented, Arduino CLI and the Library Manager indexer both have provisional support for dependency version constraints. Previously, LP048 did not have any support for the constraint syntax, which caused a spurious failure when they were in use. This commit adds support for the constraint syntax and also causes the constraint information to be used when checking if the dependency is provided by the index.
cmaglie
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.