Skip to content

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 15, 2021

These are the JSON schema-based rules to check the root and package level data of package indexes.

These are the JSON schema-based rules to check the root and package level data of package indexes.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 15, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 15, 2021 08:27
@codecov-commenter
Copy link

Codecov Report

Merging #194 (a60ecef) into main (ad3f06b) will increase coverage by 0.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   84.23%   85.15%   +0.92%     
==========================================
  Files          43       43              
  Lines        3210     3389     +179     
==========================================
+ Hits         2704     2886     +182     
+ Misses        394      392       -2     
+ Partials      112      111       -1     
Flag Coverage Δ
unit 85.15% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternal/rule/ruleconfiguration/ruleconfiguration.go 100.00% <ø> (ø)
internal/rule/rulefunction/packageindex.go 89.92% <100.00%> (+18.21%) ⬆️
internal/project/projectdata/packageindex.go 100.00% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3f06b...a60ecef. Read the comment docs.

@per1234 per1234 merged commit 5ef2649 into arduino:main Jun 15, 2021
@per1234 per1234 deleted the package-schema-rules branch June 15, 2021 08:47
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants