Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 19, 2023

Bumps github.com/stretchr/testify from 1.8.2 to 1.8.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label May 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +6.10 🎉

Comparison is base (3b8734c) 83.95% compared to head (16d73aa) 90.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   83.95%   90.05%   +6.10%     
==========================================
  Files           1       44      +43     
  Lines         162     6800    +6638     
==========================================
+ Hits          136     6124    +5988     
- Misses         17      553     +536     
- Partials        9      123     +114     
Flag Coverage Δ
unit 90.05% <ø> (+6.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@per1234 per1234 self-assigned this May 22, 2023
@per1234 per1234 added the type: enhancement Proposed improvement label May 22, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum supported Go version of the package is now 1.19:

stretchr/testify@v1.8.2...v1.8.3#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R351

We are using 1.17 for this project. Even though there is no obvious breakage, I think it is a bad idea to update the package before we migrate this project to using a supported Go version so I will put this on hold.

@per1234 per1234 added the status: on hold Do not proceed at this time label May 22, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 31, 2023

Superseded by #557.

@dependabot dependabot bot closed this May 31, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/ruledocsgen/github.com/stretchr/testify-1.8.3 branch May 31, 2023 05:59
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: on hold Do not proceed at this time labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants