-
-
Notifications
You must be signed in to change notification settings - Fork 3
add libxml2 and fix build issues #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the build environment by upgrading to libusb 1.0.28, adding libxml2, fixing Ubuntu build issues, and centralizing toolchain selection.
- Remove outdated MSVC project files and old libusb docs
- Update
build_libs.sh
to bump libusb/libusb-compat and add libxml2 build - Introduce
configure_toolchain.sh
and switch Dockerfiles to Ubuntu 22.04 with clang-13
Reviewed Changes
Copilot reviewed 299 out of 299 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
deps/libusb-1.0.26/msvc/* | Remove legacy Visual Studio project and filter files |
deps/libusb-1.0.26/libusb/* | Delete version_nano.h and darwin_usb.h (macOS backend) |
deps/libusb-1.0.26/INSTALL | Remove detailed install instructions |
deps/build_libs.sh | Bump libusb versions, comment out CMake step, add libxml2 |
configure_toolchain.sh | New script to set CC , CXX , and related toolchain vars |
Taskfile.yml | Exclude deps/* , simplify shell-file detection |
Dockerfile | Switch to Ubuntu 22.04, install clang-13, add symlinks |
Comments suppressed due to low confidence (5)
deps/libusb-1.0.26/libusb/version_nano.h:1
- Removal of
version_nano.h
deletes theLIBUSB_NANO
definition; any code checking this macro will now fail. Please update or replace this version constant to match the new libusb release.
#define LIBUSB_NANO 11724
deps/libusb-1.0.26/libusb/os/darwin_usb.h:1
- The entire Darwin USB backend header was removed, so any macOS builds will break due to missing
darwin_usb.h
. Restore this file or update the macOS build path accordingly.
/* darwin backend for libusb 1.0 */
deps/libusb-1.0.26/INSTALL:1
- [nitpick] The
INSTALL
file was deleted, removing valuable installation guidance. Consider keeping or relocating these instructions in a project-leveldocs/
directory.
Installation Instructions
Dockerfile:8
- Typo in comment: "Intall" should be "Install".
# Intall clang compiler used by macos
Taskfile.yml:118
- [nitpick] Combine the
-name
tests with-type
using parentheses to ensure the intended precedence, e.g.,( -name '*.bash' -o -name '*.sh' ) -a -type f
.
- -name '*.bash' -or -name '*.sh' -and -type f
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The repository wasn't compiling anymore due to some updates in the Ubuntu image.
The core changes are:
libusb
andlibusb-compact
libxml2
libraryconfigure_toolchain.sh
script to easily select the toolchain to useYou can now select a cross compiler by setting the
CROSS_COMPILE
env variable, for instance