Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal based installation in Linux.md #170 #196

Merged
merged 3 commits into from
May 10, 2022

Conversation

imraghavagr
Copy link
Contributor

What This PR Changes

Contribution Guidelines

@CLAassistant
Copy link

CLAassistant commented May 3, 2022

CLA assistant check
All committers have signed the CLA.

@marqdevx
Copy link
Member

marqdevx commented May 3, 2022

Thanks for the PR, need to check the version of the install.sh directory. But looks good
Let me check before I approve 👍

@marqdevx marqdevx self-assigned this May 3, 2022
@marqdevx
Copy link
Member

marqdevx commented May 4, 2022

So, from version 1.6.5 the installer contains install.sh on the "root" folder.
But in previous versions I don't find the assets folder 🤔

@marqdevx marqdevx added fix/update A small fix or update Tutorial community Bugs and fixes suggested by the community labels May 4, 2022
@imraghavagr
Copy link
Contributor Author

Yes, now the install.sh file is directly placed inside the root directory. I mentioned sudo sh assets/install.sh because the existing documentation assumes that the install.sh file is inside the assets folder and the existing command given is assets/install.sh.

But, I mentioned a NOTE about this and mentioned separate commands for both folder structures.

Shall I change the command to: sudo sh install.sh in a new commit which will only work for the latest version?

@per1234
Copy link
Contributor

per1234 commented May 4, 2022

I wouldn't bother with providing additional documentation for the installation of the <1.6.5 versions. Those are pretty outdated by now.

@marqdevx
Copy link
Member

marqdevx commented May 5, 2022

Cool, then could you please just say that the only way to install it is to use the install.sh on the root folder?
Saying a note that the version needs to be >=1.6.5
🤔 😄

@imraghavagr
Copy link
Contributor Author

imraghavagr commented May 7, 2022

Yes, since the install.sh file is in the root folder in versions >= 1.6.5, the only way to run it is by sudo sh install.sh. 😃

Should I update the doc with the following changes?

If you don't find the option to run the script from the contextual menu, you have to open a Terminal window and move into the arduino-1.6.x root directory and run the following command:

sudo sh install.sh

NOTE:

  • For version>=1.6.5
  • Remove 'sudo' keyword if already running terminal with administrative rights.

@marqdevx
Copy link
Member

marqdevx commented May 9, 2022

Yes, since the install.sh file is in the root folder in versions >= 1.6.5, the only way to run it is by sudo sh install.sh. 😃

Should I update the doc with the following changes?

If you don't find the option to run the script from the contextual menu, you have to open a Terminal window and move into the arduino-1.6.x root directory and run the following command:

sudo sh install.sh

NOTE:

* For version>=1.6.5

* Remove 'sudo' keyword if already running terminal with administrative rights.

Seems good, It would be awesome if you could update it!

@marqdevx marqdevx self-requested a review May 9, 2022 10:40
Update installation instructions in Linux.md as per the discussion.
@imraghavagr
Copy link
Contributor Author

Hi @marqdevx, I have updated the file as per our discussion. Please review it and let me know about the same. 😃

Co-authored-by: Pablo Marquínez Ferrándiz <pablomarqfer@gmail.com>
@marqdevx marqdevx self-requested a review May 10, 2022 06:19
Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for contributting 😄 @imraghavagr

@marqdevx marqdevx merged commit 3809e5b into arduino:main May 10, 2022
@imraghavagr
Copy link
Contributor Author

Thanks to you as well @marqdevx. It was a great opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants