Bugfix/file sorting #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| @@ -19,6 +19,13 @@ function listFolder(folder) { | |||
| let filePath = path.resolve(folder, f) | |||
| return !fs.lstatSync(filePath).isDirectory() | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
The old code is still commented.
ui/arduino2/store.js
Outdated
| const files = await serial.ilistFiles(path) | ||
| return files.map(f => ({ | ||
| let files = await serial.ilistFiles(path) | ||
| console.log(files) |
ui/arduino2/store.js
Outdated
| return files | ||
| } | ||
|
|
||
| function filesSortAlphabetically(entryA, entryB) { |
There was a problem hiding this comment.
I would like to propose the function name to be sortFilesAlphabetically to more or less follow the verb-noun names of other methods.
|
will update and PR again :) |
|
@murilopolese I have fixed the PR |
murilopolese
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed file sorting for both board and disk