Skip to content

Make general adjustments to project infrastructure for sync with "template" assets #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 16, 2021
Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 13, 2021

We have assembled a collection of reusable project assets:
https://github.com/arduino/tooling-project-assets
These will be used in the repositories of all Arduino tooling projects.

Some minor improvements and standardizations have been made in the upstream "template" assets, and this pull request introduces the minor global changes to the GitHub Actions workflow and taskfile. These changes should have no functional effect.

It will be followed by dedicated pull requests for the more significant and asset-specific changes.

These are the "template" workflow filenames, which are intended to serve as a unique identifier within a collection that
might include multiple related variants, and thus must be a bit more verbose.
Placement of this information at the top of the GitHub Actions workflow files, where it is easy to find and edit,
facilitates updates to the workflows as the tool versions used for project development are bumped periodically.
There are two file extensions in common use for YAML files: `.yaml` and `.yml`. Although this project uses `.yml`
exclusively for YAML files, this is a standardized workflow which might be applied to projects that have established the
use of the other extension. It will be most flexible if it supports both.
This is the naming convention established in the standardized template workflow. The tool name is "Task", with
"taskfile" being its configuration file, so the previous step name was inaccurate.
This will make it easier for the maintainers to sync fixes and improvements in either direction between the upstream
"template" assets and their installation in this repository.
These are the conventions established in the standardized "template" tasks.
A dedicated task has been added for installing the project's Python dependencies via Poetry, and this should be used
throughout the taskfile in place of redundant direct commands.
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 13, 2021
@per1234 per1234 requested review from cmaglie and umbynos August 13, 2021 12:21
@per1234 per1234 merged commit 23eda5f into arduino:main Aug 16, 2021
@per1234 per1234 deleted the sync-assets branch August 16, 2021 07:40
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants