Skip to content

Add ESP32_VS1053_Stream. #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add ESP32_VS1053_Stream. #109

merged 1 commit into from
Jun 24, 2021

Conversation

CelliesProjects
Copy link
Contributor

@github-actions
Copy link
Contributor

Arduino Lint found errors with https://github.com/CelliesProjects/ESP32_VS1053_Stream:

Linting library in ESP32_VS1053_Stream
Rule LP010 result: fail
WARNING: library.properties name value ESP32_VS1053_Stream is longer than the recommended length of 16 characters.
Rule LP020 result: fail
ERROR: library.properties version value v0.99.0 is invalid. See https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Rule LP021 result: fail
WARNING: library.properties version value v0.99.0 is not compliant with the semver specification. See https://semver.org/
Rule LP048 result: fail
WARNING: library.properties depends field item(s) ESP_VS1053_Library not found in the Library Manager index.

Finished linting project. Results:
Warning count: 3
Error count: 1
Rules passed: false

-------------------

Linting sketch in ESP32_VS1053_Stream/examples/simple

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 3
Error count: 1
Rules passed: false

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @CelliesProjects
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@CelliesProjects
Copy link
Contributor Author

Hi @ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

You can see the progress here:
https://github.com/arduino/library-registry/actions/workflows/manage-prs.yml

@github-actions
Copy link
Contributor

Arduino Lint found errors with https://github.com/CelliesProjects/ESP32_VS1053_Stream:

Linting library in ESP32_VS1053_Stream
Rule LP010 result: fail
WARNING: library.properties name value ESP32_VS1053_Stream is longer than the recommended length of 16 characters.
Rule LP020 result: fail
ERROR: library.properties version value v0.99.0 is invalid. See https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Rule LP021 result: fail
WARNING: library.properties version value v0.99.0 is not compliant with the semver specification. See https://semver.org/
Rule LP048 result: fail
WARNING: library.properties depends field item(s) ESP_VS1053_Library not found in the Library Manager index.

Finished linting project. Results:
Warning count: 3
Error count: 1
Rules passed: false

-------------------

Linting sketch in ESP32_VS1053_Stream/examples/simple

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 3
Error count: 1
Rules passed: false

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @CelliesProjects
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@CelliesProjects
Copy link
Contributor Author

Hi @ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

You can see the progress here:
https://github.com/arduino/library-registry/actions/workflows/manage-prs.yml

@github-actions
Copy link
Contributor

Arduino Lint found errors with https://github.com/CelliesProjects/ESP32_VS1053_Stream:

Linting library in ESP32_VS1053_Stream
Rule LP010 result: fail
WARNING: library.properties name value ESP32_VS1053_Stream is longer than the recommended length of 16 characters.
Rule LP020 result: fail
ERROR: library.properties version value v0.99.0 is invalid. See https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Rule LP021 result: fail
WARNING: library.properties version value v0.99.0 is not compliant with the semver specification. See https://semver.org/
Rule LP048 result: fail
WARNING: library.properties depends field item(s) ESP_VS1053_Library not found in the Library Manager index.

Finished linting project. Results:
Warning count: 3
Error count: 1
Rules passed: false

-------------------

Linting sketch in ESP32_VS1053_Stream/examples/simple

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 3
Error count: 1
Rules passed: false

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @CelliesProjects
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@CelliesProjects
Copy link
Contributor Author

Hi @ArduinoBot.

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

You can see the progress here:
https://github.com/arduino/library-registry/actions/workflows/manage-prs.yml

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/CelliesProjects/ESP32_VS1053_Stream:

Linting library in ESP32_VS1053_Stream
Rule LP010 result: fail
WARNING: library.properties name value ESP32_VS1053_Stream is longer than the recommended length of 16 characters.
Rule LP048 result: fail
WARNING: library.properties depends field item(s) ESP_VS1053_Library not found in the Library Manager index.

Finished linting project. Results:
Warning count: 2
Error count: 0
Rules passed: true

-------------------

Linting sketch in ESP32_VS1053_Stream/examples/simple

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 2
Error count: 0
Rules passed: true

@github-actions github-actions bot merged commit dbe7aea into arduino:main Jun 24, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/CelliesProjects/ESP32_VS1053_Stream/

github-actions bot pushed a commit that referenced this pull request Jun 24, 2021
@CelliesProjects CelliesProjects deleted the patch-1 branch June 24, 2021 17:12
@CelliesProjects CelliesProjects changed the title Update repositories.txt. Add https://github.com/CelliesProjects/ESP32_VS1053_Stream. Jun 24, 2021
@CelliesProjects CelliesProjects changed the title Add https://github.com/CelliesProjects/ESP32_VS1053_Stream. Add ESP32_VS1053_Stream. Jun 24, 2021
@rsora rsora added the topic: submission Add library to the list label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants