Skip to content

Add TinyGPSPlus #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add TinyGPSPlus #110

merged 2 commits into from
Jan 24, 2022

Conversation

santaimpersonator
Copy link
Contributor

Link in the TinyGPSPlus library: https://github.com/mikalhart/TinyGPSPlus

@github-actions
Copy link
Contributor

Arduino Lint found errors with https://github.com/mikalhart/TinyGPSPlus:

Linting library in TinyGPSPlus
Rule LS008 result: fail
INFO: No header file found matching library name (TinyGPS__.h). Best practices are for primary header filename to match library name.
Rule LP011 result: fail
ERROR: Prohibited character(s) in library.properties name value: TinyGPS++. See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Rule LD002 result: fail
WARNING: No license file found. See: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

Finished linting project. Results:
Warning count: 1
Error count: 1
Rules passed: false

-------------------

Linting sketch in TinyGPSPlus/examples/BasicExample

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/DeviceExample

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/FullExample

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/KitchenSink

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/SatElevTracker

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/SatelliteTracker

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Linting sketch in TinyGPSPlus/examples/UsingCustomFields

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 1
Error count: 1
Rules passed: false

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @santaimpersonator
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Jul 6, 2021

I'll add a note to myself here:

This is in progress but will require two things to happen in the library repository:

  1. Merge of Arduino library compatibility mikalhart/TinyGPSPlus#92
  2. Release of the library containing the name change provided by Arduino library compatibility mikalhart/TinyGPSPlus#92

Once those are done, the bot can be triggered again and the submission should be accepted.

@fstasi fstasi removed the submission label Sep 16, 2021
@rsora rsora added the topic: submission Add library to the list label Sep 22, 2021
@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Oct 14, 2021
@per1234 per1234 self-assigned this Nov 12, 2021
@santaimpersonator
Copy link
Contributor Author

Desired library name is taken: mikalhart/TinyGPSPlus#92 (comment)

Closing this pull request until an new library name is decided on or owner of the forked library can be reached.

@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: blocked Progress on this prevented by an external cause labels Jan 5, 2022
@santaimpersonator
Copy link
Contributor Author

Oops, jumped the gun on reopening the pull request. Need to wait for #878 and mikalhart/TinyGPSPlus#92 to be merged.

@santaimpersonator
Copy link
Contributor Author

@ArduinoBot - Retry check

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the conclusion: invalid Issue/PR not valid label Jan 24, 2022
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/mikalhart/TinyGPSPlus:

Linting library in TinyGPSPlus
WARNING: No license file found. See:                                                                                                                  
         https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
         (Rule LD002)                                                                                                                                 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in TinyGPSPlus/examples/BasicExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/DeviceExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/FullExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/KitchenSink

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/SatElevTracker

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/SatelliteTracker

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/UsingCustomFields

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to sync your fork:
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 January 24, 2022 20:13
@github-actions github-actions bot removed the request for review from per1234 January 24, 2022 20:31
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/mikalhart/TinyGPSPlus:

Linting library in TinyGPSPlus
WARNING: No license file found. See:                                                                                                                  
         https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
         (Rule LD002)                                                                                                                                 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in TinyGPSPlus/examples/BasicExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/DeviceExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/FullExample

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/KitchenSink

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/SatElevTracker

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/SatelliteTracker

Linter results for project: no errors or warnings

-------------------

Linting sketch in TinyGPSPlus/examples/UsingCustomFields

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 867c41a into arduino:main Jan 24, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/mikalhart/TinyGPSPlus/

github-actions bot pushed a commit that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants